Fix branded links and organisation logo hover state text colour #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@injms if you put |
This doesn't completely fix the issue as it only mends the focus state, which is why I didn't close the issue. I'll fix that issue separately, since the focus state was a more important issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Links on pages that used branding colours (for example, the DCM and also S About page) didn't have the correct focus state text colour.
Rough and ready patch for #1487.
What
This changes the text colour of the focus state of all of the links which use branded colours.
Before:
After:
Visual regression results:
https://government-frontend-pr-1491.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1491.herokuapp.com/component-guide