Deduplicate FAQ page schema presentation #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present we're showing the same FAQ schema on each page of a guide. This is a bit suboptimal. We have the option of splitting it up and showing one question and answer per part/chapter in the guide, but it seems much better to present it to Google as a joined up publication, because that's how it's been designed. To resolve this problem, we fall back to the Article schema for chapter pages, so we're still presenting some schema.org content, but not presenting duplicate content.
Resolved due to messages like: > DEPRECATED: Use assert_nil if expecting nil from test/services/request_helper_test.rb:7. > This will fail in Minitest 6.
bilbof
approved these changes
Sep 11, 2019
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present we're showing the same FAQ schema on each page of a guide. This is a bit suboptimal. We have the option of splitting it up and showing one question and answer per part/chapter in the guide, but it seems much better to present it to Google as a joined up publication, because that's how it's been designed.
To resolve this problem, we present the FAQ page on the default page of the guide, but fall back to the Article schema for chapter pages, so we're still presenting some schema.org content everywhere, but not presenting duplicate content.
Structured data from /universal-credit should show the FAQ schema
Structured data from /universal-credit/eligibility should show the Article schema