Adjust focus states #1466
Merged
Adjust focus states #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
9645b02 to
af6a862
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
af6a862 to
0480d00
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
0480d00 to
55cbdd0
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
55cbdd0 to
ad15ce9
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
ad15ce9 to
61a0b4a
Compare
injms
suggested changes
Sep 6, 2019
This adds the govuk-link class to multiple links throughout the codebase in order to inherit the correct styles, and updates related tests. Where the class is overridden by govuk-template the styles have been updated to use a temporary mixin to enforce the correct colour state and the class is locally overridden where white links are needed.
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
61a0b4a to
ead1217
Compare
injms
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/0OfIgpul/51-5-update-government-frontend-to-govukpublishingcomponents-v19-with-compatibility-mode-on
This adds the govuk-link class to multiple links throughout the codebase
in order to inherit the correct styles, and updates related tests. Where
the class is overridden by govuk-template the styles have been updated to
use a temporary mixin to enforce the correct colour state and the class is
locally overridden where white links are needed.
Some example urls:
contents list:
https://government-frontend-pr-1466.herokuapp.com/log-in-register-hmrc-online-services
important metadata:
https://government-frontend-pr-1466.herokuapp.com/drug-device-alerts/field-safety-notice-10-april-to-14-april-2017
https://government-frontend-pr-1466.herokuapp.com/government/fatalities/fatalities-in-afghanistan
Back to top:
https://government-frontend-pr-1466.herokuapp.com/government/publications/rates-and-allowances-income-tax/income-tax-rates-and-allowances-current-and-past
Parts:
https://government-frontend-pr-1466.herokuapp.com/foreign-travel-advice/turkey
Component guide for this PR:
https://government-frontend-pr-1466.herokuapp.com/component-guide