Upgrade to publishing components v19 #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
2b6fba6 to
85a9a7d
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
85a9a7d to
66ab617
Compare
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
2 times, most recently
from
58989d5 to
d4055d8
Compare
maxgds
changed the title
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
2 times, most recently
from
51f272b to
1df45d9
Compare
chao-xian
previously requested changes
Sep 3, 2019
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
1df45d9 to
73fad00
Compare
- with colour and rem fallback flags
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
2 times, most recently
from
0aab74c to
5a895ba
Compare
andysellick
reviewed
Sep 4, 2019
| @@ -36,7 +36,6 @@ | |||
| } | |||
|
|
|||
| .app-c-back-to-top { | |||
| color: $link-colour; | |||
There was a problem hiding this comment.
I'd suggest putting the govuk-link class on the elements in place of the stuff that's been removed here.
| @@ -1,16 +1,26 @@ | |||
| .app-c-published-dates { | |||
| @include core-16; | |||
There was a problem hiding this comment.
Again, you could try govuk-link on this element. I'm going to stop writing comments on this because there's a lot of them, the main benefit is that with the additional link class we're not duplicating the focus styles every time the mixin is called.
vanitabarrett
previously requested changes
Sep 4, 2019
There was a problem hiding this comment.
Most of my comments have already been noted by @andysellick 🙂
- Link redirected to live site.
Changes made: - Explicitly adding the focus state multiple times - Adding a class to hang the focus state off where necessary - Removing "@include core-16" as it isn't needed and it introduces line spacing that makes the focus state overlap - Removing an explicitly set link colour that overrode the focus state - Adding breathing space to the print link
maxgds
force-pushed
the
upgrade-to-publishing-components-v18
branch
from
5a895ba to
a3091eb
Compare
andysellick
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The upgrade to version 19 of the component gem will bring in the changes made to version 3 of GOV.UK Design System.
The legacy colours flag is turned on, and the legacy font size is set to be used. (There will be a separate pull request to remove this legacy code and to turn on the new colour palette.)
Why
The improvements include a new focus state, which will help this app to reach the WCAG 2.1 standard. It also has a tonne of other improvements that cascade from Design System, such as the new smaller font.
Visual regression results
https://government-frontend-pr-1448.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1448.herokuapp.com/component-guide