Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump faker from 1.9.6 to 2.1.0 #1432

Merged
merged 2 commits into from
Aug 7, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 31, 2019

Bumps faker from 1.9.6 to 2.1.0.

Release notes

Sourced from faker's releases.

v2.1.0

v2.1.0 (2019-31-07)

Bug/Fixes

This change required a quick release because it's a breaking issue. Every place where I18n.l() was used began to display the wrong date, causing test suite to fail and frustration for developers.

Release Faker 2.0

v2.0 (2019-31-07)

Important Note:

Version 2 has several breaking changes. We replaced positional arguments with keyword arguments and the list below contains all the changed methods:

  • Faker::Books::Dune.quote(character = nil) becomes Faker::Books::Dune.quote(character: nil)
  • Faker::Books::Dune.saying(source = nil) becomes Faker::Books::Dune.saying(source: nil)
  • Faker::Books::Lovecraft.fhtagn(number_of = nil) becomes Faker::Books::Lovecraft.fhtagn(number: nil)
  • Faker::Books::Lovecraft.paragraph(sentence_count = nil, random_sentences_to_add = nil) becomes Faker::Books::Lovecraft.paragraph(sentence_count: nil, random_sentences_to_add: nil)
  • Faker::Books::Lovecraft.paragraph_by_chars(chars = nil) becomes Faker::Books::Lovecraft.paragraph_by_chars(characters: nil)
  • Faker::Books::Lovecraft.paragraphs(paragraph_count = nil) becomes Faker::Books::Lovecraft.paragraphs(number: nil)
  • Faker::Books::Lovecraft.sentence(word_count = nil, random_words_to_add = nil) becomes Faker::Books::Lovecraft.sentence(word_count: nil, random_words_to_add: nil)
  • Faker::Books::Lovecraft.sentences(sentence_count = nil) becomes Faker::Books::Lovecraft.sentences(number: nil)
  • Faker::Books::Lovecraft.words(num = nil, spaces_allowed = nil) becomes Faker::Books::Lovecraft.words(number: nil, spaces_allowed: nil)
  • Faker::Address.city(options = nil) becomes Faker::Address.city(options: nil)
  • Faker::Address.postcode(state_abbreviation = nil) becomes Faker::Address.postcode(state_abbreviation: nil)
  • Faker::Address.street_address(include_secondary = nil) becomes Faker::Address.street_address(include_secondary: nil)
  • Faker::Address.zip(state_abbreviation = nil) becomes Faker::Address.zip(state_abbreviation: nil)
  • Faker::Address.zip_code(state_abbreviation = nil) becomes Faker::Address.zip_code(state_abbreviation: nil)
  • Faker::Alphanumeric.alpha(char_count = nil) becomes Faker::Alphanumeric.alpha(number: nil)
  • Faker::Alphanumeric.alphanumeric(char_count = nil) becomes Faker::Alphanumeric.alphanumeric(number: nil)
  • Faker::Avatar.image(slug = nil, size = nil, format = nil, set = nil, bgset = nil) becomes Faker::Avatar.image(slug: nil, size: nil, format: nil, set: nil, bgset: nil)
  • Faker::Bank.account_number(digits = nil) becomes Faker::Bank.account_number(digits: nil)
  • Faker::Bank.iban(country_code = nil) becomes Faker::Bank.iban(country_code: nil)
  • Faker::ChileRut.full_rut(min_rut = nil, fixed = nil) becomes Faker::ChileRut.full_rut(min_rut: nil, fixed: nil)
  • Faker::ChileRut.rut(min_rut = nil, fixed = nil) becomes Faker::ChileRut.rut(min_rut: nil, fixed: nil)
  • Faker::Code.ean(base = nil) becomes Faker::Code.ean(base: nil)
  • Faker::Code.isbn(base = nil) becomes Faker::Code.isbn(base: nil)
  • Faker::Code.nric(min_age = nil, max_age = nil) becomes Faker::Code.nric(min_age: nil, max_age: nil)
  • Faker::Commerce.department(max = nil, fixed_amount = nil) becomes Faker::Commerce.department(max: nil, fixed_amount: nil)
  • Faker::Commerce.price(range = nil, as_string = nil) becomes Faker::Commerce.price(range: nil, as_string: nil)
  • Faker::Commerce.promotion_code(digits = nil) becomes Faker::Commerce.promotion_code(digits: nil)
  • Faker::Company.polish_register_of_national_economy(length = nil) becomes Faker::Company.polish_register_of_national_economy(length: nil)
  • Faker::CryptoCoin.acronym(coin = nil) becomes Faker::CryptoCoin.acronym(coin: nil)
  • Faker::CryptoCoin.coin_name(coin = nil) becomes Faker::CryptoCoin.coin_name(coin: nil)
  • Faker::CryptoCoin.url_logo(coin = nil) becomes Faker::CryptoCoin.url_logo(coin: nil)
  • Faker::Date.backward(days = nil) becomes Faker::Date.backward(days: nil)
  • Faker::Date.between(from, to) becomes Faker::Date.between(from:, to:)
  • Faker::Date.between_except(from, to, excepted) becomes Faker::Date.between_except(from:, to:, excepted:)
  • Faker::Date.birthday(min_age = nil, max_age = nil) becomes Faker::Date.birthday(min_age: nil, max_age: nil)
  • Faker::Date.forward(days = nil) becomes Faker::Date.forward(days: nil)
... (truncated)
Changelog

Sourced from faker's changelog.

v2.1.0 (2019-31-07)

Bug/Fixes

This change required a quick release because it's a breaking issue. Every place where I18n.l() was used began to display the wrong date, causing test suite to fail.


v2.0 (2019-31-07)

Important Note:

Version 2 has several breaking changes. We replaced positional arguments with keyword arguments and the list below contains all the changed methods:

  • Faker::Books::Dune.quote(character = nil) becomes Faker::Books::Dune.quote(character: nil)
  • Faker::Books::Dune.saying(source = nil) becomes Faker::Books::Dune.saying(source: nil)
  • Faker::Books::Lovecraft.fhtagn(number_of = nil) becomes Faker::Books::Lovecraft.fhtagn(number: nil)
  • Faker::Books::Lovecraft.paragraph(sentence_count = nil, random_sentences_to_add = nil) becomes Faker::Books::Lovecraft.paragraph(sentence_count: nil, random_sentences_to_add: nil)
  • Faker::Books::Lovecraft.paragraph_by_chars(chars = nil) becomes Faker::Books::Lovecraft.paragraph_by_chars(characters: nil)
  • Faker::Books::Lovecraft.paragraphs(paragraph_count = nil) becomes Faker::Books::Lovecraft.paragraphs(number: nil)
  • Faker::Books::Lovecraft.sentence(word_count = nil, random_words_to_add = nil) becomes Faker::Books::Lovecraft.sentence(word_count: nil, random_words_to_add: nil)
  • Faker::Books::Lovecraft.sentences(sentence_count = nil) becomes Faker::Books::Lovecraft.sentences(number: nil)
  • Faker::Books::Lovecraft.words(num = nil, spaces_allowed = nil) becomes Faker::Books::Lovecraft.words(number: nil, spaces_allowed: nil)
  • Faker::Address.city(options = nil) becomes Faker::Address.city(options: nil)
  • Faker::Address.postcode(state_abbreviation = nil) becomes Faker::Address.postcode(state_abbreviation: nil)
  • Faker::Address.street_address(include_secondary = nil) becomes Faker::Address.street_address(include_secondary: nil)
  • Faker::Address.zip(state_abbreviation = nil) becomes Faker::Address.zip(state_abbreviation: nil)
  • Faker::Address.zip_code(state_abbreviation = nil) becomes Faker::Address.zip_code(state_abbreviation: nil)
  • Faker::Alphanumeric.alpha(char_count = nil) becomes Faker::Alphanumeric.alpha(number: nil)
  • Faker::Alphanumeric.alphanumeric(char_count = nil) becomes Faker::Alphanumeric.alphanumeric(number: nil)
  • Faker::Avatar.image(slug = nil, size = nil, format = nil, set = nil, bgset = nil) becomes Faker::Avatar.image(slug: nil, size: nil, format: nil, set: nil, bgset: nil)
  • Faker::Bank.account_number(digits = nil) becomes Faker::Bank.account_number(digits: nil)
  • Faker::Bank.iban(country_code = nil) becomes Faker::Bank.iban(country_code: nil)
  • Faker::ChileRut.full_rut(min_rut = nil, fixed = nil) becomes Faker::ChileRut.full_rut(min_rut: nil, fixed: nil)
  • Faker::ChileRut.rut(min_rut = nil, fixed = nil) becomes Faker::ChileRut.rut(min_rut: nil, fixed: nil)
  • Faker::Code.ean(base = nil) becomes Faker::Code.ean(base: nil)
  • Faker::Code.isbn(base = nil) becomes Faker::Code.isbn(base: nil)
  • Faker::Code.nric(min_age = nil, max_age = nil) becomes Faker::Code.nric(min_age: nil, max_age: nil)
  • Faker::Commerce.department(max = nil, fixed_amount = nil) becomes Faker::Commerce.department(max: nil, fixed_amount: nil)
  • Faker::Commerce.price(range = nil, as_string = nil) becomes Faker::Commerce.price(range: nil, as_string: nil)
  • Faker::Commerce.promotion_code(digits = nil) becomes Faker::Commerce.promotion_code(digits: nil)
  • Faker::Company.polish_register_of_national_economy(length = nil) becomes Faker::Company.polish_register_of_national_economy(length: nil)
  • Faker::CryptoCoin.acronym(coin = nil) becomes Faker::CryptoCoin.acronym(coin: nil)
  • Faker::CryptoCoin.coin_name(coin = nil) becomes Faker::CryptoCoin.coin_name(coin: nil)
  • Faker::CryptoCoin.url_logo(coin = nil) becomes Faker::CryptoCoin.url_logo(coin: nil)
  • Faker::Date.backward(days = nil) becomes Faker::Date.backward(days: nil)
  • Faker::Date.between(from, to) becomes Faker::Date.between(from:, to:)
  • Faker::Date.between_except(from, to, excepted) becomes Faker::Date.between_except(from:, to:, excepted:)
  • Faker::Date.birthday(min_age = nil, max_age = nil) becomes Faker::Date.birthday(min_age: nil, max_age: nil)
  • Faker::Date.forward(days = nil) becomes Faker::Date.forward(days: nil)
... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@AlanGabbianelli
Copy link
Contributor

@dependabot-bot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/faker-2.1.0 branch from b9c833e to 98ec26e Compare August 6, 2019 15:56
Version 2 of Faker has several breaking changes. One that affects us is
this:

`Faker::Lorem.characters(char_count = nil)`
becomes
`Faker::Lorem.characters(number: nil)`
@AlanGabbianelli AlanGabbianelli merged commit 48d5100 into master Aug 7, 2019
@AlanGabbianelli AlanGabbianelli deleted the dependabot/bundler/faker-2.1.0 branch August 7, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants