Force English for metadata #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgds
force-pushed
the
published-english
branch
from
c2aaab7 to
8a18980
Compare
maxgds
force-pushed
the
published-english
branch
from
8a18980 to
5961d81
Compare
chao-xian
suggested changes
Jul 17, 2019
| <% if link_to_history && history.empty? %> | ||
| — <a href="#history"><%= t('components.published_dates.see_all_updates') %></a> | ||
| — <a href="#history">see all updates</a> |
There was a problem hiding this comment.
Rather than hardcode the text here, we can be explicit about which locale translation we want to use: <%= t('components.published_dates.see_all_updates', locale: :en) %>
| <% elsif history.any? %> | ||
| <a href="#full-history" | ||
| class="app-c-published-dates__toggle" | ||
| data-controls="full-history" | ||
| data-expanded="false" | ||
| data-toggled-text="- <%= t('components.published_dates.hide_all_updates') %>">+ <%= t('components.published_dates.show_all_updates') | ||
| %></a> | ||
| data-toggled-text="- hide all updates">+ show all updates</a> |
There was a problem hiding this comment.
As above, we can specify the locale in the translation by passing the locale: :en param.
On translated pages we are largely failing to translate the metadata, leading to messy strings where the only translated content is the month or the word "and" amongst otherwise English sentences. This change sets the locale to English for the dates, and reverts attempts to translate other sections of the page, and it marks the components as being in English. It removes classnames that aren't used from the CSS and forces the text direction to be left-to-right for these components. This marks the page up more semantically, and supports a better experience for screenreader users as they can now context switch the language appropriately.
maxgds
force-pushed
the
published-english
branch
from
5961d81 to
2017156
Compare
chao-xian
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/YjWKQe6Z/12-update-metadata-component-for-language
On translated pages we are largely failing to translate the metadata,
leading to messy strings where the only translated content is the month
or the word "and" amongst otherwise English sentences.
This change sets the locale to English for the dates, and reverts attempts
to translate other sections of the page, and it marks the components
as being in English. It removes classnames that aren't used from the CSS
and forces the text direction to be left-to-right for these components.
This marks the page up more semantically, and supports a better experience
for screenreader users as they can now context switch the language
appropriately.
Relevant urls:
https://www.gov.uk/government/news/death-of-former-prime-minister-lady-thatcher.ar
https://www.gov.uk/government/news/death-of-former-prime-minister-lady-thatcher.es
https://www.gov.uk/government/news/death-of-former-prime-minister-lady-thatcher.ur
https://www.gov.uk/government/news/ambassador-hobbs-inaugurates-social-projects-in-the-department-of-san-pedro.es-419
Screenshots
Before
After