Add Govuk-Use-Recommended-Links Vary response header and value header #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
reviewed
Jun 26, 2019
barrucadu
approved these changes
Jun 26, 2019
karlbaker02
force-pushed
the
set-response-header-for-related-links
branch
from
6085185 to
5ae92a0
Compare
This commit adds the `Govuk-Use-Recommended-Links` Vary response header and value header to responses generated by the `ContentItemsController`. This is to enable cache invalidation of previous responses if the incoming `Govuk-Use-Recommended-Links` request header changes state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Govuk-Use-Recommended-LinksVary response header and value header to responses generated by theContentItemsController. This is to enable cache invalidation of previous responses if the incomingGovuk-Use-Recommended-Linksrequest header changes state.Visual regression results:
https://government-frontend-pr-1397.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1397.herokuapp.com/component-guide