Display new recommended related links #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrucadu
reviewed
Jun 21, 2019
barrucadu
reviewed
Jun 21, 2019
barrucadu
reviewed
Jun 21, 2019
karlbaker02
force-pushed
the
add-automated-related-links
branch
from
b423810 to
bedfa6b
Compare
karlbaker02
force-pushed
the
add-automated-related-links
branch
from
bedfa6b to
84ca1b1
Compare
barrucadu
approved these changes
Jun 25, 2019
karlbaker02
force-pushed
the
add-automated-related-links
branch
from
84ca1b1 to
4e92118
Compare
This commit adds support for the new recommended related links to be shown based on the existence of a HTTP header set by our CDN. To achieve this we add support in general for feature flags via a `FeatureToggler` class. Should the header exist, the new recommended related links will only be shown if there are no existing `ordered_related_items` in the content item, to ensure that we do not override manually curated links. Solo: @karlbaker02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new recommended related links to be shown based on the existence of a HTTP header set by our CDN. To achieve this we add support in general for feature flags via a
FeatureTogglerclass.Should the header exist, the new recommended related links will only be shown if there are no existing
ordered_related_itemsin the content item, to ensure that we do not override manually curated links.Dependent on alphagov/govuk-content-schemas#908.
Visual regression results:
https://government-frontend-pr-1386.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1386.herokuapp.com/component-guide