Display withdrawal notices on translated editions in English #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardkerry
force-pushed
the
remove_translations_from_withdrawal_notice
branch
from
48d53da to
fe41b8e
Compare
edwardkerry
force-pushed
the
remove_translations_from_withdrawal_notice
branch
from
40de1e1 to
9343593
Compare
edwardkerry
force-pushed
the
remove_translations_from_withdrawal_notice
branch
from
9343593 to
3f640cd
Compare
thomasleese
approved these changes
Apr 18, 2019
… languages Currently a withdrawn translated edition may display the majority of the withdrawal notice title in English, but with dates and publication type in the chosen locale. Until withdrawal notices are also available via I18n, this PR will ensure only English is displayed.
edwardkerry
force-pushed
the
remove_translations_from_withdrawal_notice
branch
from
8a660b6 to
31203cf
Compare
thomasleese
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a withdrawn translated edition may display the majority of the
withdrawal notice title in English, but with dates and publication type
in the chosen locale.
Until withdrawal notices are also available via I18n, this PR will ensure
only English is displayed.
before
after
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide