Add new locales #1294
Merged
Add new locales #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are adding support for: Croatian: hr Danish: da Dutch: nl Finish fi Icelandic is Irish gd Norwegian: no Maltese: mt Slovenian: sl Swedish: sv Add the locale codes to `config/application.rb` to enable them and also add the files to `config/locales`. No translations are currently provided in the locale files. These will be added at a later date. For now, we just need to enable adding translations to publications for these languages. Note that in config/locales/en.yml we've enclosed "no" in quotes. This is because in YAML no is a [reserved word](https://yaml.org/type/bool.html). We use rails_translation_manager to regenerate our locale files. When rails_translation_manager loads the YAML and interprets "no" as a bool instead of a locale, it breaks.
thomasleese
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding support for:
Croatian: hr
Danish: da
Dutch: nl
Finish fi
Icelandic is
Irish gd
Norwegian: no
Maltese: mt
Slovenian: sl
Swedish: sv
Add the locale codes to
config/application.rbto enable them and also addthe files to
config/locales. No translations are currently provided inthe locale files. These will be added at a later date. For now, we just
need to enable adding translations to publications for these languages.
Note that in config/locales/en.yml we've enclosed "no" in quotes. This
is because in YAML no is a reserved word.
We use rails_translation_manager to regenerate our locale files.
When rails_translation_manager loads the YAML and interprets
"no" as a bool instead of a locale, it breaks.
Trello