Move the webchat readme to doc folder #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have `app/assets/javascripts/webchat/README.md` which looks like developer documentation to me. It currently gets precompiled as an asset and seems to take around 27seconds. That seems like a waste of time.
thomasleese
approved these changes
Feb 27, 2019
|
wow, what on earth does it do with it for 27 seconds? |
|
🤷♀️ marks up the mark down 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have
app/assets/javascripts/webchat/README.mdwhich lookslike developer documentation to me. It currently gets precompiled as an
asset and seems to take around 27seconds. That seems like a waste of
time.
On my local machine running
RAILS_ENV=test bundle exec rake assets:precompileI get:Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide