Upgrade govuk_publishing_components to 13.6.1 #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the govuk_publishing_components gem to version `13.6.1`.
This commit fixes the assertions made in `choose_sign_in_test.rb` on the error-summary component provided by govuk_publishing_components. This component was upgraded in version `13.5.3` to use govuk-frontend styles, which in turn broke the assertions made here (see PR alphagov/govuk_publishing_components#692 for details). Solo: @karlbaker02
tijmenb
reviewed
Feb 8, 2019
| assert page.has_css?(".gem-c-error-summary") | ||
| assert page.has_css?(".gem-c-error-summary__title", text: 'You haven’t selected an option') | ||
| assert page.has_css?(".gem-c-error-summary__link[href='#option-0']", text: 'Please select an option') | ||
| assert page.has_css?(".govuk-error-summary") |
There was a problem hiding this comment.
These assertions were too tightly coupled to the component implementation in the gem. To avoid this happening again, perhaps we can just test for the existence of "You haven’t selected an option" on this page, without checking for the CSS generated by the gem (which should be internal).
alex-ju
previously approved these changes
Feb 8, 2019
This commit updates the test `renders errors correctly` to make it less dependent on styling changes in `govuk_publishing_components` - this is how the tests broke when upgrading from `13.5.2` to `13.5.3`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the govuk_publishing_components gem to version
13.6.1.Visual regression results:
https://government-frontend-pr-1223.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1223.herokuapp.com/component-guide