Add related links A/B test #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilbof
previously approved these changes
Jan 29, 2019
karlbaker02
force-pushed
the
add-related-links-a-b-test
branch
from
29fe405 to
f93580b
Compare
karlbaker02
changed the title
added 4 commits
February 12, 2019 09:45
…hey exist and when running the B variant of the test
… related links do not exist. Previously, a user on the B variant would have seen related links of the control variant if the test variant contained no related links, as `ordered_related_items` would not have been overridden on the content item. This commit fixes that problem, to ensure a fair test. This commit also renames `RelatedLinksABTest` to `RelatedLinksABTest1` in anticipation of multiple test iterations. Solo: @karlbaker02
karlbaker02
force-pushed
the
add-related-links-a-b-test
branch
from
a86eee9 to
876edc4
Compare
sihugh
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Related Links A/B test, showing a different set of related links on the B variant from the content item's suggested_ordered_related_items, where it exists. It also updates the current RelatedLinksAATest to be RelatedLinksABTest.
Trello: https://trello.com/c/byNrHEMw
Visual regression results:
https://government-frontend-pr-1223.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1223.herokuapp.com/component-guide