Add related links A/A test to all routes #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new concern `AATestable`, which will be used to run an A/A test to determine variance in our metrics and help guide metrics to use for upcoming A/B tests on related links. Solo: @karlbaker02
sihugh
approved these changes
Jan 17, 2019
There was a problem hiding this comment.
Approved, but we probably shouldn't merge this until https://gov.uk/help/cookies includes the information for this test.
|
@sihugh Thanks, that is being sorted as we speak. |
|
Actually we can merge and deploy this because the cookie doesn't get set unless I've deployed the CDN changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new concern
AATestable, which will be used to run an A/A test to determinevariance in our metrics and help guide metrics to use for upcoming A/B tests on related links.
Solo: @karlbaker02
Visual regression results:
https://government-frontend-pr-1211.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1211.herokuapp.com/component-guide