Use default news image on news article pages #1175
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a news article doesn't have an image, we use its primary publishing organisation's default image.
|
Just had a little dig into this and noticed on at least some documents there is an extra hash in Has this been considered or is the standard image url okay? |
|
@1pretz1 Sure, at the moment government-frontend is using the url rather than the high res url for images when a news article has one, so we're just using the same logic here for default news images and using url. |
|
@emmabeynon Okay cool! 👍 |
emmabeynon
deleted the
display-org-default-image-on-news-article-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://trello.com/c/UXUxzEv4/512-amend-government-frontend-logic-to-use-default-organisation-image
In cases where a news article doesn't have an image, we use its primary
publishing organisation's default image.