Track events and pageviews #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track events and pageviews when tracking radio groups across domains. The pageview data is also required when performing cross domain tracking, also add some test coverage for radio group tracking.
thomasleese
approved these changes
Oct 8, 2018
Cross domain tracking should behave the same way as normal event tracking so include event labels including the -with-hint prefix for parity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/CbTYssq1/478-enable-cross-domain-tracking-for-cysp-govuk-sign-in-pages
Track events and pageviews when tracking radio groups across domains.
The pageview data is also required when performing cross domain tracking,
also add some test coverage for radio group tracking.
Also makes a copy of event tracking options so that cross domain config doesn't change the original config object.
Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide