Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Capybara driver timeout #1121

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Increase Capybara driver timeout #1121

merged 2 commits into from
Oct 5, 2018

Conversation

steventux
Copy link
Contributor

Master branch is failing on CI because

[build] Error:
[build] ServiceSignIn::ChooseSignInTest#test_renders_errors_correctly:
[build] Net::ReadTimeout: Net::ReadTimeout
[build]     test/integration/service_sign_in/choose_sign_in_test.rb:116:in `setup_and_visit_choose_sign_in_page'
[build]     test/integration/service_sign_in/choose_sign_in_test.rb:53:in `block in <class:ChooseSignInTest>'
[build] 
[build] bin/rails test test/integration/service_sign_in/choose_sign_in_test.rb:52

Looking at previous fails it can be any test, but always the first to call #visit.
teamcapybara/capybara#1305 implies the problem may be asset compilation.
I've increased the timeout and this seems to allow builds to pass.

These go up to eleven

Visual regression results:
https://government-frontend-pr-[THIS PR NUMBER].surge.sh/gallery.html

Component guide for this PR:
https://government-frontend-pr-[THIS PR NUMBER].herokuapp.com/component-guide

Steve Laing added 2 commits October 5, 2018 12:06
Add custom chrome driver config
7cae3e6
Increase default Selenium driver timeout
c4d03d5 
It's common for the first net http request to fail, supposedly due to
the length of time asset compilation can take. Increase the default
timeout to 90 seconds.
@steventux steventux changed the title Debug net timeout test fail Increase Capybara driver timeout Oct 5, 2018
barrucadu
barrucadu approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@barrucadu barrucadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests failed on the commit which used the default timeout, and passed on the commit which increased it. Pretty convincing to me!

@steventux steventux merged commit feeb69a into master Oct 5, 2018
@steventux steventux deleted the debug-net-timeout-test-fail branch October 5, 2018 12:27
bevanloon pushed a commit that referenced this pull request Feb 20, 2019
Increase Capybara timeouts
7ea90b4 
Master is failing with Net::ReadTimeout errors. We have
[previously](#1121)
increased timeouts which seemed to solve the problem. Let's hope the
magic works again.

At the same time, we are getting a deprecation warning:

```
WARN Selenium [DEPRECATION] :timeout= is deprecated. Use #read_timeout= and #open_timeout= instead.
```

so I have changed `.timeout` to use the new `read_timeout` instead.
@bevanloon bevanloon mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barrucadu barrucadu barrucadu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steventux @barrucadu @benthorner