Resolve linting errors #1112
Merged
Resolve linting errors #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilbof
force-pushed
the
billfranklin/resolve-linting-issues
branch
from
1cf46b7 to
1cd23d2
Compare
cbaines
reviewed
Oct 9, 2018
| @@ -4,7 +4,7 @@ atom_feed(root_url: @content_item.web_url, id: @content_item.web_url) do |feed| | |||
| feed.author do |author| | |||
| author.name "GOV.UK" | |||
| end | |||
| feed.entry(@content_item, id: "#{@content_item.web_url}##{@content_item.atom_public_updated_at}", url: @content_item.web_url, updated: @content_item.atom_public_updated_at) do |entry| | |||
| feed.entry(@content_item, id: "#{@content_item.web_url}##{@content_item.atom_public_updated_at.iso8601}", url: @content_item.web_url, updated: @content_item.atom_public_updated_at) do |entry| | |||
There was a problem hiding this comment.
With this change here, do you know what effect it has (if any)?
added 6 commits
October 12, 2018 09:38
bilbof
force-pushed
the
billfranklin/resolve-linting-issues
branch
from
1cd23d2 to
1b18a84
Compare
cbaines
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to alphagov/feedback#522, this resolves any linting issues in this repository raised by
govuk-lint-ruby.Visual regression results:
https://government-frontend-pr-1112.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1112.herokuapp.com/component-guide