Add cross domain tracking to service sign in form #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
add-cross-domain-tracking-to-service-sign-in-format
branch
from
76229e4 to
3138ef7
Compare
steventux
force-pushed
the
add-cross-domain-tracking-to-service-sign-in-format
branch
from
3138ef7 to
92d932a
Compare
thomasleese
approved these changes
Sep 27, 2018
We need to track radio button selection events across domains so that other departments can monitor the efficacy of changes and options on the service sign in pages. This commit modifies the track radio group module to include cross domain tracking via a tracking code and name. Support is being added for radio buttons to pass the relevant url so that the hostname can be identified as part of the tracking.
This provides support for the tracking url to enable cross domain tracking in the track radio group module.
steventux
force-pushed
the
add-cross-domain-tracking-to-service-sign-in-format
branch
from
878960f to
cc046ed
Compare
steventux
deleted the
add-cross-domain-tracking-to-service-sign-in-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/CbTYssq1/478-enable-cross-domain-tracking-for-cysp-govuk-sign-in-pages
Depends on alphagov/govuk_publishing_components#539 and alphagov/govuk-content-schemas#817
We need to track radio button selection events across domains
so that other departments can monitor the efficacy of changes
and options on the service sign in pages. This commit modifies
the track radio group module to include cross domain tracking
via a tracking code and name. Support is being added for radio
buttons to pass the relevant url so that the hostname can be
identified as part of the tracking.
Visual regression results:
https://government-frontend-pr-1102.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1102.herokuapp.com/component-guide