Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arabic and Russian translations for navigation headings #1055

Merged
merged 5 commits into from
Sep 3, 2018
Merged

Add Arabic and Russian translations for navigation headings #1055

merged 5 commits into from
Sep 3, 2018

Conversation

barrucadu
Copy link
Contributor

@barrucadu barrucadu commented Aug 16, 2018 •
edited
Loading

@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 16, 2018 09:53 Inactive
brucebolt
brucebolt approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@brucebolt brucebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok from a technical point of view. I can't comment on the language content as a non-Arabic and non-Russian speaker!

@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 08:27 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 08:29 Inactive
@barrucadu barrucadu mentioned this pull request Aug 17, 2018
Closed
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 08:32 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 08:40 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 09:06 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 09:14 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 09:42 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 09:47 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 09:50 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 10:05 Inactive
@benthorner benthorner temporarily deployed to government-frontend-pr-1055 August 17, 2018 10:08 Inactive
@barrucadu barrucadu changed the title [DO NOT MERGE] Add Arabic and Russian translations for navigation headings Add Arabic and Russian translations for navigation headings Sep 3, 2018
@barrucadu barrucadu merged commit dcddd7b into master Sep 3, 2018
@barrucadu barrucadu deleted the msw/translations branch September 3, 2018 09:56
@barrucadu barrucadu restored the msw/translations branch September 3, 2018 10:49
@barrucadu barrucadu mentioned this pull request Sep 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brucebolt brucebolt brucebolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrucadu @brucebolt @benthorner