Add tracking for our new taxonomy navigation #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
approved these changes
Aug 15, 2018
| @@ -91,23 +91,42 @@ def load_taxonomy_navigation | |||
| .map { |document_collection| document_collection.values_at('base_path', 'title') } | |||
|
|
|||
| # Fetch link attributes of parent step by steps required to render the top navigation banner | |||
| @banner_items = @content_item | |||
| @step_by_step_links = @content_item | |||
There was a problem hiding this comment.
We don't need @step_by_step_links, or @taxon_links to be instance variables, only @banner_items.
| .sort_by { |taxon| taxon[:taxon_name] } | ||
| .map { |taxon| taxon.values_at('title', 'base_path') } | ||
| .map { |taxon| taxon.values_at('title', 'base_path') << "Taxon" } |
There was a problem hiding this comment.
Why do we need to append "Taxon" to the mapped attributes?
There was a problem hiding this comment.
Good spot, we don't any more, that was my previous attempt at a solution! Will remove
vanitabarrett
force-pushed
the
add-tracking-to-taxonomy-nav
branch
from
b12af32 to
2a9faf9
Compare
vanitabarrett
force-pushed
the
add-tracking-to-taxonomy-nav
branch
from
2a9faf9 to
aaaf82c
Compare
| end | ||
| end | ||
| end | ||
|
|
||
| def format_banner_links(links, type) | ||
| links.each.with_index(1).map do |link, index| |
There was a problem hiding this comment.
You can do map do |(title, base_path), index|, then the arguments supplied to link_to will be a little more expressive.
vanitabarrett
force-pushed
the
add-tracking-to-taxonomy-nav
branch
from
aaaf82c to
9984905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/CALq4uG8/132-add-tracking-for-ab-test
Adds Google Analytics tracking to Topic, Collection, related taxon and step by step links.
Banner with taxon and step by step links:
Topic & Collection links:
How to test
You will need to have an extension like ModHeader installed in your browser to see the B Variant. The values should be:
Request Header Name: GOVUK-ABTest-ContentPagesNav
Request Header Value: B
To see Google Analytics events firing in the Dev Tools console, you need an extension like Google Analytics Debugger
Tagged to one taxon
Tagged to multiple taxons
Tagged to a taxon without services
Not tagged to any taxons