Fix intermittent failing test #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarwyatt
changed the title
oscarwyatt
changed the title
sihugh
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes intermittently failing test. HTML dumps show the content was being rendered but the assertion was still failing. Making capybara wait slightly longer, only in this test, while making an assertion fixes the tests (locally at least). Additionally, fixes occasional error when the rails config isn't loaded
More information on why this occurs:
https://spin.atomicobject.com/2012/04/27/intermittent-test-failures/
In the section entitled "Not waiting long enough"
Visual regression results:
https://government-frontend-pr-1052.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1052.herokuapp.com/component-guide