-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collections to publisher metadata if B variant #1049
Conversation
This might be a design question: do we want "and 2 others" as well as "+ show all"? I think previously we've combined the two, so "+ 2 others" (for example) becomes the toggle link. |
When I looked at this with Alan for the top banner we had a couple of assumption that led to this approach:
|
<a href="#" | ||
data-controls="<%= toggle_id %>" | ||
data-expanded="false" | ||
data-toggled-text="− hide all">+ show all</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably be translated strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vanitabarrett I've added translation support with 3a01e37 but we don't have actual translations.
4897126
to
3a01e37
Compare
d2e9c59
to
2fb963f
Compare
@andrewgarner As this is a change to the publisher metadata component, we probably need to add a test in |
2fb963f
to
09dde92
Compare
09dde92
to
4e4b894
Compare
https://trello.com/c/kcZ8VQS7
Visual regression results:
https://government-frontend-pr-1049.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1049.herokuapp.com/component-guide