Add banner to the taxonomy navigation #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgarner
force-pushed
the
taxonomy-navigation-top-banner-links
branch
from
54e2350 to
3d2d674
Compare
sihugh
reviewed
Aug 13, 2018
| .content_item | ||
| .dig('links', 'part_of_step_navs') | ||
| .yield_self { |part_of_step_navs| part_of_step_navs || [] } | ||
| .select { |step_by_step_nav| step_by_step_nav['document_type'] == 'step_by_step_nav' } |
There was a problem hiding this comment.
part_of_step_navs should only contain step_by_step_nav documents so we can remove this line if we want.
| @@ -97,6 +97,20 @@ def load_taxonomy_navigation | |||
| .yield_self { |document_collections| document_collections || [] } | |||
| .select { |document_collection| document_collection['document_type'] == 'document_collection' } | |||
| .map { |document_collection| document_collection.values_at('base_path', 'title') } | |||
|
|
|||
| @banner_items = @content_item | |||
There was a problem hiding this comment.
Could we extract this to give it some context? It's a bit hard to mentally parse something this long, so might benefit from pulled out and given a name?
| <% navigation = GovukPublishingComponents::Presenters::ContextualNavigation.new(@content_item.content_item.parsed_content, request.path) %> | ||
|
|
||
| <% if @tagged_taxons.present? || navigation.breadcrumbs.present? %> | ||
| <div class='gem-c-contextual-breadcrumbs'> |
There was a problem hiding this comment.
I'll need to remember to communicate that we're doing this 📣
andrewgarner
force-pushed
the
taxonomy-navigation-top-banner-links
branch
from
3d2d674 to
4546de0
Compare
andrewgarner
force-pushed
the
taxonomy-navigation-top-banner-links
branch
from
4546de0 to
3156396
Compare
This adds a breadcrumb and a banner navigation element listing things a content item is part of. If the content item is tagged to a single topic a full breadcrumb to it is shown. If it is tagged to multiple topics then a home breadcrumb is shown and the topics are listed in the banner. Some examples: - One topic and step by step: /vehicle-insurance - Multiple topics and a step by step: /vehicle-registration/new-and-used-vehicles - One topic, no step by step: /pay-dartford-crossing-charge https://trello.com/c/rznwkADc
andrewgarner
force-pushed
the
taxonomy-navigation-top-banner-links
branch
from
3156396 to
6500259
Compare
sihugh
approved these changes
Aug 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a breadcrumb and a banner navigation element listing things a content item is part of.
If the content item is tagged to a single topic a full breadcrumb to it is shown. If it is tagged to multiple topics then a home breadcrumb is shown and the topics are listed in the banner.
Some examples:
One topic and step by step:
/vehicle-insuranceMultiple topics and a step by step:
/vehicle-registration/new-and-used-vehiclesOne topic, no step by step:
/pay-dartford-crossing-chargehttps://trello.com/c/rznwkADc
Visual regression results:
https://government-frontend-pr-1041.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1041.herokuapp.com/component-guide