Fix taxonomy navigation (AB) small link font & refactor CSS #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 3, 2018 13:42
Link text for Topic and Collection links was 14px on mobile. We shouldn't really be using 14px font-size on mobile, especially not for important links. Other content surrounding that was also using 16px, so we should match that.
Re-organise the CSS so it follows the HTML order - makes it easier to read Replace $gutter / 6 with $gutter-one-third / 2
We were overriding the CSS for the heading component. It's bad practice to do this, we should instead make use of the parameters which can be passed into the component. This will make the headings render as 19px on desktop and 16px on mobile (as opposed to 16px on all devices).
sihugh
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/I9TueAJ5/95-font-size-of-topics-collections-on-mobile-is-small
This PR:
Before (mobile)
After (mobile)
Before (desktop)
After (desktop)
Component guide for this PR:
https://government-frontend-pr-1020.herokuapp.com/component-guide
Example:
https://government-frontend-pr-1020.herokuapp.com/government/publications/academies-finance-and-assurance-steering-group-terms-of-reference?ABTest-ContentPagesNav=B