Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show taxon breadcrumbs for b variant #1013

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

oscarwyatt
Copy link
Contributor

@oscarwyatt oscarwyatt commented Aug 1, 2018

Show taxon breadcrumbs if there are live taxons for a content item in variant B

Visual regression results:
https://government-frontend-pr-1013.surge.sh/gallery.html

Component guide for this PR:
https://government-frontend-pr-1013.herokuapp.com/component-guide

https://trello.com/c/yZfYuiJp/84-use-taxons-breadcrumb-in-b-sample

@benthorner benthorner temporarily deployed to government-frontend-pr-1013 August 1, 2018 07:41 Inactive
@oscarwyatt oscarwyatt requested a review from sihugh August 1, 2018 07:41
@oscarwyatt oscarwyatt force-pushed the show-taxon-breadcrumbs-for-b-variant branch from d5fde99 to 9e31827 Compare August 1, 2018 07:48
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-1013 August 1, 2018 07:48 Inactive
@oscarwyatt oscarwyatt force-pushed the show-taxon-breadcrumbs-for-b-variant branch from 9e31827 to 8152def Compare August 1, 2018 08:00
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-1013 August 1, 2018 08:00 Inactive
@oscarwyatt oscarwyatt force-pushed the show-taxon-breadcrumbs-for-b-variant branch from 8152def to 23ca6d5 Compare August 1, 2018 08:03
@boffbowsh boffbowsh temporarily deployed to government-frontend-pr-1013 August 1, 2018 08:03 Inactive
Show b variant for contextual breadcrumbs

add blah

remove tab
@oscarwyatt oscarwyatt force-pushed the show-taxon-breadcrumbs-for-b-variant branch from 23ca6d5 to 8f174d5 Compare August 1, 2018 08:05
@sihugh sihugh merged commit 2056d39 into master Aug 1, 2018
@sihugh sihugh deleted the show-taxon-breadcrumbs-for-b-variant branch August 1, 2018 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants