Taxonomy navigation collections #1008
Conversation
No longer display related collections in the sidebar if the new navigation is enabled.
| .taxonomy-navigation__section:first-of-type { | ||
| margin-top: $gutter * 1.5; | ||
| .taxonomy-navigation__row { | ||
| display: flex; |
There was a problem hiding this comment.
Is there a reason why this needs to use flex rather than just the grid classes (grid-row and column-one-third)?
There was a problem hiding this comment.
So that they line up with the highlight boxes below.
There was a problem hiding this comment.
I think it can still line up without flex? Quick testing in the herokuapp looks ok:
There was a problem hiding this comment.
The breakpoints are different:
Grid:
Flex:
There was a problem hiding this comment.
Ah I see, I didn't spot that - that's annoying! Thanks for explaining.
I wonder if we need it to match up or if we could just have each column half the width of that row. But using flex isn't a big deal, it just adds a lot of CSS.
There was a problem hiding this comment.
It was something @miaallers mentioned when we went through it together. I should imagine we can find a better way to implement if the AB test is positive.
andrewgarner
force-pushed
the
taxonomy-navigation-collections
branch
from
49091b5 to
6f1c843
Compare
| @include bold-24; | ||
| display: block; | ||
| .taxonomy-navigation__list-item { | ||
| margin-bottom: $gutter / 6; |
There was a problem hiding this comment.
At this point it might just be more useful to write it out as 5px or perhaps $gutter-one-third / 2
There was a problem hiding this comment.
Same for padding-bottom below
| <div class="taxonomy-navigation__row"> | ||
| <div class="taxonomy-navigation__column"> | ||
| <%= render "govuk_publishing_components/components/heading", | ||
| text: 'Topics', |
There was a problem hiding this comment.
Need to make this a translated string
| <% if related_collections.any? %> | ||
| <div class="taxonomy-navigation__column"> | ||
| <%= render "govuk_publishing_components/components/heading", | ||
| text: 'Collections', |
There was a problem hiding this comment.
Also need to add this as a translated string
Moves related collections from the sidebar to the taxonomy navigation.
Before:
After:
https://trello.com/c/zUWqJgX9
Visual regression results:
https://government-frontend-pr-1008.surge.sh/gallery.html
Component guide for this PR:
https://government-frontend-pr-1008.herokuapp.com/component-guide