Add the news and communications section #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihugh
force-pushed
the
news-announcements-nav
branch
from
e9ab068 to
489e42e
Compare
sihugh
changed the title
sihugh
changed the title
vanitabarrett
suggested changes
Jul 31, 2018
| href: promo[:link][:path], | ||
| heading_text: promo[:link][:text], | ||
| image_src: promo[:image][:url], | ||
| image_alt: "", |
There was a problem hiding this comment.
We should be able to get the actual alt text of the image in news_and_communications.rb, I'd only set alt to "" if we're using the placeholder image.
There was a problem hiding this comment.
Ah yes, I think we talked about this in the accessibility session. I should have been a bit more overt. I think when the image is part of a link it should use the link text instead of the alt text? (I may be wrong).
Either way, I can add the alt text and it shouldn't make anything worse. 👍
Adding this flushed out that we were making an unnecessary request when taxon ids weren't provided.
Using guids can be confusing for future us
News and comms are different from the other sections in that we show the image from the article if it's a featured link (and the image is present). This will be updated in future to get content images from rummager which removes the need to call content store for each item. We'll also update this to display results as one list rather than separate items.
sihugh
force-pushed
the
news-announcements-nav
branch
from
489e42e to
4e66117
Compare
vanitabarrett
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
News and communications are displayed differently from the other sections in that we show images from articles for the first three items. We'll show a placeholder if there isn't an image.
This functionality will be updated in future to get content images from rummager which removes the need to call content store for each item.
We'll also update this to display results as one list rather than as separate items. We have this as an item in the backlog, but it'll need work on a couple of components to achieve
I've also added tests for the services supergroup presenter, as these were missing
Examples:
You will need to have an extension like ModHeader installed in your browser to see the B Variant. The values should be:
Request Header Name: GOVUK-ABTest-ContentPagesNav
Request Header Value: B
Component guide for this PR:
https://government-frontend-pr-1002.herokuapp.com/component-guide
https://trello.com/c/XCqGIGZE/49-get-most-recent-news-and-communications-data