Skip to content

Commit

Permalink
Remove banner from DCMS about page
Browse files Browse the repository at this point in the history
Content request: DCMS [1] has now been closed and we can remove the org is
changing banner. department-for-business-energy-and-industrial-strategy
and department-for-international-trade will be closing soon, at which
point we can remove this bespoke banner code entirely.

We also need to remove the banner code for the actual org page which
lives in collections. Once an org is closed in Whitehall the bespoke
banner gets replaced automatically as a different view is rendered [2]
vs [3]. This means we don't have to remove each orgs custom banner as it
gets replaced anyway. We will still need to remove the banner code in
Collections when all three orgs are closed.

[1]: https://www.gov.uk/government/organisations/department-for-digital-culture-media-sport/
[2]: https://github.com/alphagov/collections/blob/6ded61a31a81b7c053151bf74c80c2cd84d001e8/app/views/organisations/separate_website.html.erb#L11-L13
[3]: https://github.com/alphagov/collections/blob/6ded61a31a81b7c053151bf74c80c2cd84d001e8/app/views/organisations/show.html.erb#L7-L13
  • Loading branch information
1pretz1 committed Mar 29, 2023
1 parent 2954560 commit e201c7b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion app/presenters/corporate_information_page_presenter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class CorporateInformationPagePresenter < ContentItemPresenter
ORG_CHANGING_BANNER_BASE_PATHS = %w[
/government/organisations/department-for-business-energy-and-industrial-strategy/about
/government/organisations/department-for-international-trade/about
/government/organisations/department-for-digital-culture-media-sport/about
].freeze

def page_title
Expand Down

0 comments on commit e201c7b

Please sign in to comment.