Skip to content

Commit

Permalink
Fix incorrect links on /government/get-involved
Browse files Browse the repository at this point in the history
These links were incorrect, presumably they are an artefact from what
was used to copy+paste from originally.

Interestingly these links actually have explicit tests in Smokey [1].
But it turns out they don't actually test correctly as they don't have
an expect step [2].

As it is quite unusual to test at the fidelity of individual links in
HTML (they're just testing you typed the same thing afterall) I've not
added replacement tests.

[1]: https://github.com/alphagov/smokey/blob/7553a432259d785fb6d4fb81cfd4fe3572185ad3/features/apps/government_frontend.feature#L23-L47
[2]: https://github.com/alphagov/smokey/blob/7553a432259d785fb6d4fb81cfd4fe3572185ad3/features/step_definitions/get_involved_page_steps.rb#L39-L41
  • Loading branch information
kevindew committed Jun 29, 2022
1 parent e97f01e commit c9c338b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/views/content_items/get_involved.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@
<%= render "govuk_publishing_components/components/big_number", {
number: @open_consultation_count,
label: t('get_involved.open_consultations'),
href: "/government/organisations#ministerial_departments"
href: "/search/policy-papers-and-consultations?content_store_document_type=open_consultations"
} %>
</div>
<div class="govuk-grid-column-two-thirds">
<%= render "govuk_publishing_components/components/big_number", {
number: @closed_consultation_count,
label: t('get_involved.closed_consultations'),
href: "/government/organisations#ministerial_departments"
href: "/search/policy-papers-and-consultations?content_store_document_type=closed_consultations"
} %>
</div>
</div>
Expand Down

0 comments on commit c9c338b

Please sign in to comment.