Appease the stylesheets linter

alphagov · May 13, 2022 · b1f9f7f · b1f9f7f
1 parent 1766d0a
commit b1f9f7f
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 92 deletions.
diff --git a/app/assets/stylesheets/views/_manual.scss b/app/assets/stylesheets/views/_manual.scss
@@ -1,111 +1,112 @@
 .manuals-frontend-body {
   padding-bottom: govuk-spacing(6);
+}
 
-  header {
-    background: $govuk-brand-colour;
+.manuals-header {
+  @include govuk-font(16);
+  @include govuk-clearfix;
 
-    &.hmrc {
-      background: govuk-organisation-colour("hm-revenue-customs");
-    }
+  background: $govuk-brand-colour;
+  color: govuk-colour('white');
+  margin: 0;
+  padding-bottom: govuk-spacing(6);
+  padding-top: govuk-spacing(6);
+
+  @include govuk-media-query($from: tablet) {
+    padding: govuk-spacing(6) govuk-spacing(3);
+  }
 
-    padding-top: govuk-spacing(6);
-    padding-bottom: govuk-spacing(6);
-    color: govuk-colour("white");
-    margin: 0;
-    @include govuk-font(16);
-    @include govuk-clearfix;
+  .manual-type {
+    @include govuk-font(24);
+  }
+
+  h1 {
+    @include govuk-font(36, $weight: bold);
+    padding: 0 0 govuk-spacing(3);
 
     @include govuk-media-query($from: tablet) {
-      padding: govuk-spacing(6) govuk-spacing(3);
+      padding: 0 0 govuk-spacing(6);
     }
+  }
 
-    .manual-type {
-      @include govuk-font(24);
+  a {
+    color: govuk-colour('white');
+
+    &:focus {
+      @include govuk-focused-text;
     }
+  }
 
-    h1 {
-      @include govuk-font(36, $weight: bold);
-      padding: 0 0 govuk-spacing(3) 0;
+  &.hmrc {
+    background: govuk-organisation-colour('hm-revenue-customs');
+  }
+}
 
-      @include govuk-media-query($from: tablet) {
-        padding: 0 0 govuk-spacing(6) 0;
-      }
-    }
+.section-list {
+  margin-top: govuk-spacing(6);
+  padding: 0;
+
+  @include govuk-media-query($from: tablet) {
+    margin-top: govuk-spacing(9);
+  }
+}
 
-    a {
-      color: govuk-colour("white");
+.section-list-item {
+  @include govuk-font(19);
 
-      &:focus {
-        @include govuk-focused-text;
-      }
-    }
+  border-top: 1px solid $govuk-border-colour;
+  cursor: pointer;
+  list-style: none;
+
+  &:hover {
+    background-color: govuk-colour("light-grey", $legacy: 'grey-4');
   }
 
-  .section-list {
-    margin-top: govuk-spacing(6);
-    padding: 0;
+  &:last-child {
+    border-bottom: 1px solid $govuk-border-colour;
+  }
+}
 
-    @include govuk-media-query($from: tablet) {
-      margin-top: govuk-spacing(9);
-    }
+.section-link {
+  display: block;
+  padding: govuk-spacing(2) govuk-spacing(2) govuk-spacing(2) 0;
+  text-decoration: none;
 
-    li {
-      @include govuk-font(19);
-      list-style: none;
-      cursor: pointer;
-      border-top: 1px solid $govuk-border-colour;
+  @include govuk-media-query($from: tablet) {
+    padding-right: 33.3333%;
+  }
 
-      &:hover {
-        background-color: govuk-colour("light-grey", $legacy: "grey-4");
-      }
+  &:focus {
+    @include govuk-focused-text;
+  }
 
-      &:last-child {
-        border-bottom: 1px solid $govuk-border-colour;
-      }
+  .subsection-title-text {
+    @include govuk-typography-weight-bold;
+    @include govuk-link-decoration;
+    display: block;
+  }
 
-      a {
-        text-decoration: none;
-        display: block;
-        padding: govuk-spacing(2) govuk-spacing(2) govuk-spacing(2) 0;
-
-        &:focus {
-          @include govuk-focused-text;
-        }
-
-        @include govuk-media-query($from: tablet) {
-          padding-right: 33.3333%;
-        }
-
-        .subsection-title-text {
-          @include govuk-typography-weight-bold;
-          @include govuk-link-decoration;
-          display: block;
-        }
-
-        .subsection-summary {
-          color: $govuk-text-colour;
-          display: block;
-        }
-
-        &:hover {
-          .subsection-title-text {
-            @include govuk-link-hover-decoration;
-          }
-        }
-      }
-    }
+  .subsection-summary {
+    color: $govuk-text-colour;
+    display: block;
   }
 
-  .manual-body {
-    @include govuk-media-query($from: tablet) {
-      margin-top: govuk-spacing(6);
+  &:hover {
+    .subsection-title-text {
+      @include govuk-link-hover-decoration;
     }
+  }
+}
 
-    .section-title {
-      @include govuk-text-colour;
-      @include govuk-font($size: 24, $weight: bold);
-      @include govuk-responsive-margin(4, "bottom");
-    }
+.manual-body {
+  @include govuk-media-query($from: tablet) {
+    margin-top: govuk-spacing(6);
+  }
+
+  .section-title {
+    @include govuk-text-colour;
+    @include govuk-font($size: 24, $weight: bold);
+    @include govuk-responsive-margin(4, 'bottom');
   }
 }
 
@@ -134,10 +135,10 @@
   a {
     padding-right: 0;
   }
-}
 
-.subsection-id {
-  color: $govuk-secondary-text-colour;
-  min-width: 135px;
-  padding-right: govuk-spacing(3);
+  .subsection-id {
+    color: $govuk-secondary-text-colour;
+    min-width: 135px;
+    padding-right: govuk-spacing(3);
+  }
 }
diff --git a/app/views/content_items/manuals/_header.html.erb b/app/views/content_items/manuals/_header.html.erb
@@ -1,4 +1,4 @@
-<header aria-labelledby="manual-title" class="govuk-grid-row">
+<header aria-labelledby="manual-title" class="govuk-grid-row manuals-header">
   <div class='govuk-grid-column-two-thirds'>
 
     <%= render "govuk_publishing_components/components/heading", {

diff --git a/app/views/content_items/manuals/_hmrc_header.html.erb b/app/views/content_items/manuals/_hmrc_header.html.erb
@@ -1,4 +1,4 @@
-<header aria-labelledby="manual-title" class="hmrc govuk-grid-row">
+<header aria-labelledby="manual-title" class="manuals-header hmrc govuk-grid-row">
   <div class="govuk-grid-column-two-thirds">
 
     <span class="manual-type"><%= I18n.t("manuals.hmrc_manual_type") %></span>

diff --git a/app/views/content_items/manuals/_hmrc_sections.html.erb b/app/views/content_items/manuals/_hmrc_sections.html.erb
@@ -4,8 +4,8 @@
 
 <ol class="section-list hmrc">
   <% group["child_sections"].each do |section| %>
-    <li>
-      <%= link_to section["base_path"], class: "govuk-link" do %>
+    <li class="section-list-item">
+      <%= link_to section["base_path"], class: "govuk-link section-link" do %>
       <div class="title-wrap">
         <% if section["section_id"] %>
           <div class="subsection-id"><%= section["section_id"] %></div>