Skip to content

Commit

Permalink
Merge pull request #2939 from alphagov/ga4-change-updates-type
Browse files Browse the repository at this point in the history
Change GA4 type for show/hide updates accordions
  • Loading branch information
AshGDS authored Sep 28, 2023
2 parents e215a4c + dfabfda commit 910a716
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/views/components/_published_dates.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
data-expanded="false"
data-toggled-text="&#45;&nbsp;<%= t('components.published_dates.hide_all_updates', locale: :en) %>"
data-module="ga4-event-tracker"
data-ga4-event="<%= {event_name: "select_content", type: "content", section: "Footer"}.to_json %>"
data-ga4-event="<%= {event_name: "select_content", type: "content history", section: "Footer"}.to_json %>"
data-ga4-expandable
>&#43;&nbsp;<%= t('components.published_dates.show_all_updates', locale: :en) %></a>
<div class="app-c-published-dates__change-history js-hidden" id="full-history">
Expand Down
2 changes: 1 addition & 1 deletion app/views/content_items/service_manual_guide.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
data-toggled-text="- Hide all page updates (<%= @content_item.previous_changes.length %>)"
data-expanded="false"
data-module="ga4-event-tracker"
data-ga4-event="<%= {event_name: "select_content", type: "content", section: "Footer"}.to_json %>"
data-ga4-event="<%= {event_name: "select_content", type: "content history", section: "Footer"}.to_json %>"
data-ga4-expandable
role="button"
aria-controls="full-history"
Expand Down
2 changes: 1 addition & 1 deletion test/components/published_dates_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def component_name

expected_ga4_json = {
"event_name": "select_content",
"type": "content",
"type": "content history",
"section": "Footer",
}.to_json

Expand Down

0 comments on commit 910a716

Please sign in to comment.