Skip to content

Commit

Permalink
Restore original wording for travel advice emails
Browse files Browse the repository at this point in the history
This has been requested by FCDO [1], and agreed with GOV.UK Notify,
who originally asked for the word "alert" to be removed so that it
did not conflict with the upcoming emergency alert pages on GOV.UK.
Note the original change was applied via the default text changing
in GOV.UK Publishing Components [2].

[1]: https://govuk.zendesk.com/agent/tickets/4417745
[2]: alphagov/govuk_publishing_components@36953fd
  • Loading branch information
Ben Thorner committed Feb 17, 2021
1 parent 22712c6 commit 8b06938
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion app/views/content_items/travel_advice.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@
<%= render "govuk_publishing_components/components/contents_list", contents: @content_item.part_link_elements, underline_links: true %>
</nav>

<%= render 'govuk_publishing_components/components/subscription_links', email_signup_link: @content_item.email_signup_link, feed_link: @content_item.feed_link %>
<%= render 'govuk_publishing_components/components/subscription_links',
email_signup_link: @content_item.email_signup_link,
email_signup_link_text: "Get email alerts",
feed_link: @content_item.feed_link %>
</aside>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion test/integration/travel_advice_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class TravelAdviceTest < ActionDispatch::IntegrationTest
assert page.has_css?("title", visible: false, text: @content_item["title"])
assert_has_component_title(@content_item["details"]["country"]["name"])

assert page.has_css?("a[href=\"#{@content_item['details']['email_signup_link']}\"]", text: "Get emails")
assert page.has_css?("a[href=\"#{@content_item['details']['email_signup_link']}\"]", text: "Get email alerts")
assert page.has_css?("a[href=\"#{@content_item['base_path']}.atom\"]", text: "Subscribe to feed")

assert page.has_css?(".part-navigation li", count: @content_item["details"]["parts"].size + 1)
Expand Down

0 comments on commit 8b06938

Please sign in to comment.