Reset <dl> styles in important-metadata component

This component was probably relying on a reset stylesheet that has been removed and now adds the browser default margins to the dl and dd elements. We reset those values in the component stylesheet.
alphagov · Mar 3, 2022 · 5ef73b6 · 5ef73b6
1 parent add72c3
commit 5ef73b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/assets/stylesheets/components/_important-metadata.scss b/app/assets/stylesheets/components/_important-metadata.scss
@@ -21,11 +21,16 @@
   margin-bottom: 5px;
 }
 
+.app-c-important-metadata__list {
+  margin: 0;
+}
+
 .app-c-important-metadata__term {
   float: left;
   padding-right: govuk-spacing(1);
 }
 
 .app-c-important-metadata__definition {
+  margin: 0;
   font-weight: bold;
 }
diff --git a/app/views/components/_important-metadata.html.erb b/app/views/components/_important-metadata.html.erb
@@ -10,7 +10,7 @@
     <% if title %>
       <h2 class="app-c-important-metadata__title"><%= sanitize title %></h2>
     <% end %>
-    <dl data-module="gem-track-click">
+    <dl class="app-c-important-metadata__list" data-module="gem-track-click">
     <% items.each do |title, definition| %>
       <dt class="app-c-important-metadata__term"><%= sanitize title.to_s %>: </dt>
       <dd class="app-c-important-metadata__definition"><%= sanitize definition %></dd>