Skip to content

Commit

Permalink
Remove scss_lint-govuk
Browse files Browse the repository at this point in the history
This has been replaced by stylelint.
  • Loading branch information
kevindew committed Jan 8, 2021
1 parent 4865595 commit 54de016
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 24 deletions.
1 change: 0 additions & 1 deletion .scss-lint.yml

This file was deleted.

1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ group :development, :test do
gem "jasmine"
gem "jasmine_selenium_runner"
gem "rubocop-govuk"
gem "scss_lint-govuk", require: false
end

group :development do
Expand Down
13 changes: 0 additions & 13 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,6 @@ GEM
rainbow (3.0.0)
raindrops (0.19.1)
rake (13.0.3)
rb-fsevent (0.10.4)
rb-inotify (0.10.1)
ffi (~> 1.0)
regexp_parser (1.8.2)
request_store (1.5.0)
rack (>= 1.4)
Expand Down Expand Up @@ -292,11 +289,6 @@ GEM
ruby2_keywords (0.0.2)
rubyzip (2.3.0)
safe_yaml (1.0.5)
sass (3.7.4)
sass-listen (~> 4.0.0)
sass-listen (4.0.0)
rb-fsevent (~> 0.9, >= 0.9.4)
rb-inotify (~> 0.9, >= 0.9.7)
sassc (2.4.0)
ffi (~> 1.9)
sassc-rails (2.1.2)
Expand All @@ -305,10 +297,6 @@ GEM
sprockets (> 3.0)
sprockets-rails
tilt
scss_lint (0.59.0)
sass (~> 3.5, >= 3.5.5)
scss_lint-govuk (0.2.0)
scss_lint
selenium-webdriver (3.142.7)
childprocess (>= 0.5, < 4.0)
rubyzip (>= 1.2.2)
Expand Down Expand Up @@ -403,7 +391,6 @@ DEPENDENCIES
rails_translation_manager
rubocop-govuk
sassc-rails
scss_lint-govuk
simplecov
slimmer
uglifier
Expand Down
1 change: 1 addition & 0 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ node {
govuk.setEnvar("PUBLISHING_E2E_TESTS_COMMAND", "test-government-frontend")
govuk.buildProject(
beforeTest: { sh("yarn install") },
sassLint: false,
publishingE2ETests: true,
brakeman: true,
)
Expand Down
10 changes: 1 addition & 9 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,10 @@ Rails.application.load_tasks

unless Rails.env.production?
require "rubocop/rake_task"
require "scss_lint/rake_task"

RuboCop::RakeTask.new(:rubocop) do |t|
t.patterns = %w[app config test Gemfile]
end

SCSSLint::RakeTask.new do |t|
t.files = Dir.glob(["app/assets/stylesheets"])
end

task default: %i[scss_lint spec rubocop]

desc "Lint Ruby and SCSS files"
task lint: %i[rubocop scss_lint]
task default: %i[spec rubocop]
end

0 comments on commit 54de016

Please sign in to comment.