Remove trailing and leading whitespace from change notes

alphagov · Jan 15, 2020 · 4b2a61f · 4b2a61f
1 parent be3274a
commit 4b2a61f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/app/views/components/_published-dates.html.erb b/app/views/components/_published-dates.html.erb
@@ -26,7 +26,7 @@
           <% history.each do |change| %>
             <li class="app-c-published-dates__change-item">
               <time class="app-c-published-dates__change-date timestamp" datetime="<%= change[:timestamp] %>"><%= change[:display_time] %></time>
-              <p class="app-c-published-dates__change-note"><%= change[:note] %></p>
+              <p class="app-c-published-dates__change-note"><%= change[:note].strip %></p>
             </li>
           <% end %>
         </ol>

diff --git a/test/components/published_dates_test.rb b/test/components/published_dates_test.rb
@@ -35,6 +35,16 @@ def component_name
     assert_select ".app-c-published-dates--history .app-c-published-dates__change-date", text: "23 August 2013"
   end
 
+  test "strips leading and trailing whitespace from note text" do
+    render_component(
+      published: "1st November 2000",
+      last_updated: "15th July 2015",
+      history: [display_time: "23 August 2013", note: "Updated with new data"],
+    )
+    assert_select ".app-c-published-dates__change-history#full-history"
+    assert_select ".app-c-published-dates--history .app-c-published-dates__change-note", text: /^\S/
+  end
+
   test "only adds history id when passed page history" do
     render_component(published: "1st November 2000")
     assert_select "#history", false, "should only render history id if passed history item"