Merge pull request #1796 from alphagov/dependabot/bundler/rubocop-gov…

…uk-3.16.0 Bump rubocop-govuk from 3.15.0 to 3.16.0
alphagov · Jun 12, 2020 · 45c522c · 45c522c
2 parents 1445025 + a9cec97
commit 45c522c
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 19 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -54,7 +54,7 @@ GEM
     asset_bom_removal-rails (1.0.2)
       rails (>= 4.2)
       sass (> 3.4)
-    ast (2.4.0)
+    ast (2.4.1)
     better_errors (2.7.1)
       coderay (>= 1.0.0)
       erubi (>= 1.0.0)
@@ -236,7 +236,7 @@ GEM
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    regexp_parser (1.7.0)
+    regexp_parser (1.7.1)
     request_store (1.5.0)
       rack (>= 1.4)
     rest-client (2.1.0)
@@ -247,7 +247,7 @@ GEM
     rexml (3.2.4)
     robotex (1.0.0)
     rouge (3.20.0)
-    rubocop (0.85.0)
+    rubocop (0.85.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
@@ -258,15 +258,15 @@ GEM
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (0.0.3)
       parser (>= 2.7.0.1)
-    rubocop-govuk (3.15.0)
-      rubocop (= 0.85.0)
-      rubocop-rails (~> 2)
-      rubocop-rake (~> 0.5.1)
-      rubocop-rspec (~> 1.28)
-    rubocop-rails (2.5.2)
-      activesupport
+    rubocop-govuk (3.16.0)
+      rubocop (= 0.85.1)
+      rubocop-rails (= 2.6.0)
+      rubocop-rake (= 0.5.1)
+      rubocop-rspec (= 1.39.0)
+    rubocop-rails (2.6.0)
+      activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.72.0)
+      rubocop (>= 0.82.0)
     rubocop-rake (0.5.1)
       rubocop
     rubocop-rspec (1.39.0)

diff --git a/app/presenters/content_item/corporate_information_groups.rb b/app/presenters/content_item/corporate_information_groups.rb
@@ -9,8 +9,7 @@ def corporate_information?
     def corporate_information
       corporate_information_groups.map do |group|
         {
-          heading: view_context.content_tag(
-            :h3,
+          heading: view_context.tag.h3(
             group["name"],
             id: group_title_id(group["name"]),
           ),
@@ -20,8 +19,7 @@ def corporate_information
     end
 
     def corporate_information_heading_tag
-      view_context.content_tag(
-        :h2,
+      view_context.tag.h2(
         corporate_information_heading[:text],
         id: corporate_information_heading[:id],
       )

diff --git a/app/presenters/content_item/withdrawable.rb b/app/presenters/content_item/withdrawable.rb
@@ -33,8 +33,7 @@ def withdrawal_notice_context
     end
 
     def withdrawal_notice_time
-      view_context.content_tag(
-        :time,
+      view_context.tag.time(
         english_display_date(withdrawal_notice["withdrawn_at"]),
         datetime: withdrawal_notice["withdrawn_at"],
       )

diff --git a/app/presenters/speech_presenter.rb b/app/presenters/speech_presenter.rb
@@ -39,7 +39,7 @@ def location
 
   def delivered_on
     delivered_on_date = content_item["details"]["delivered_on"]
-    view_context.content_tag(:time, display_date(delivered_on_date), datetime: delivered_on_date)
+    view_context.tag.time(display_date(delivered_on_date), datetime: delivered_on_date)
   end
 
   def speech_type_explanation

diff --git a/app/presenters/travel_advice_presenter.rb b/app/presenters/travel_advice_presenter.rb
@@ -77,7 +77,7 @@ def alert_status
     alert_statuses = alert_statuses.map do |alert|
       if allowed_statuses.include?(alert)
         copy = I18n.t("travel_advice.alert_status.#{alert}").html_safe
-        view_context.content_tag(:p, copy)
+        view_context.tag.p(copy)
       end
     end