Skip to content

Commit

Permalink
Remove module from parent class
Browse files Browse the repository at this point in the history
Currently we are requiring the single page notification button module
in all the subclasses inheriting from ContentItemPresenter. We will be adding
more into this module in coming work, so it's a good idea to remove unecessary
coupling now.
  • Loading branch information
hannako committed Nov 4, 2022
1 parent 07cb5d3 commit 4228bb8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion app/presenters/content_item_presenter.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
class ContentItemPresenter
include ContentItem::Withdrawable
include ContentItem::SinglePageNotificationButton
attr_reader :content_item,
:requested_path,
:view_context,
Expand Down Expand Up @@ -47,6 +46,10 @@ def requesting_a_service_sign_in_page?
false
end

def has_single_page_notifications?
false
end

def available_translations
translations = content_item["links"]["available_translations"] || []

Expand Down

0 comments on commit 4228bb8

Please sign in to comment.