Skip to content

Commit

Permalink
Update related links A/B test variant
Browse files Browse the repository at this point in the history
This commit updates the A/B test variant for related links from `RelatedLinksABTest1` to `RelatedLinksABTest2`. This is to support the second iteration of the A/B test which is using a new set of related link data.
  • Loading branch information
Karl Baker committed Feb 21, 2019
1 parent 4b9c422 commit 2a1f0af
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion app/controllers/concerns/ab_testable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def related_links_variant

def related_links_test
@related_links_test ||= GovukAbTesting::AbTest.new(
"RelatedLinksABTest1",
"RelatedLinksABTest2",
dimension: RELATED_LINKS_DIMENSION,
allowed_variants: %w(A B),
control_variant: "A"
Expand Down
12 changes: 6 additions & 6 deletions test/controllers/content_items_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,8 @@ class ContentItemsControllerTest < ActionController::TestCase
assert_equal content_item['title'], assigns[:content_item].title
end

test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest1 control variant" do
with_variant RelatedLinksABTest1: 'A' do
test "gets item from the content store and keeps ordered_related_items when running RelatedLinksABTest2 control variant" do
with_variant RelatedLinksABTest2: 'A' do
content_item = content_store_has_schema_example('case_study', 'case_study')

get :show, params: { path: path_for(content_item) }
Expand All @@ -140,8 +140,8 @@ class ContentItemsControllerTest < ActionController::TestCase
end
end

test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest1 test variant" do
with_variant RelatedLinksABTest1: 'B' do
test "gets item from the content store and replaces ordered_related_items when running RelatedLinksABTest2 test variant" do
with_variant RelatedLinksABTest2: 'B' do
content_item = content_store_has_schema_example('case_study', 'case_study')

get :show, params: { path: path_for(content_item) }
Expand All @@ -150,8 +150,8 @@ class ContentItemsControllerTest < ActionController::TestCase
end
end

test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest1 test variant has no suggestions" do
with_variant RelatedLinksABTest1: 'B' do
test "gets item from the content store and replaces ordered_related_items when empty array when RelatedLinksABTest2 test variant has no suggestions" do
with_variant RelatedLinksABTest2: 'B' do
content_item = content_store_has_schema_example('guide', 'guide')

get :show, params: { path: path_for(content_item) }
Expand Down
4 changes: 2 additions & 2 deletions test/controllers/development_controller_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ class DevelopmentControllerTest < ActionController::TestCase
include GovukAbTesting::MinitestHelpers

%w(A B).each do |test_variant|
test "RelatedLinksABTest1 works correctly for each variant (variant: #{test_variant})" do
with_variant RelatedLinksABTest1: test_variant do
test "RelatedLinksABTest2 works correctly for each variant (variant: #{test_variant})" do
with_variant RelatedLinksABTest2: test_variant do
get :index

ab_test = @controller.send(:related_links_test)
Expand Down

0 comments on commit 2a1f0af

Please sign in to comment.