Merge pull request #2303 from alphagov/fix-sticky-js

Fixes sticky element glitch
alphagov · Nov 26, 2021 · 0940ef7 · 0940ef7
2 parents 3a377fb + d3df85a
commit 0940ef7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/assets/javascripts/modules/sticky-element-container.js b/app/assets/javascripts/modules/sticky-element-container.js
@@ -26,8 +26,8 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
   StickyElementContainer.prototype.init = function () {
     if (!this.stickyElement) return
 
-    window.onresize = this.onResize
-    window.onscroll = this.onScroll
+    window.onresize = this.onResize.bind(this)
+    window.onscroll = this.onScroll.bind(this)
     setInterval(this.checkResize.bind(this), this.interval)
     setInterval(this.checkScroll.bind(this), this.interval)
     this.checkResize()
@@ -71,7 +71,6 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
   StickyElementContainer.prototype.checkScroll = function () {
     if (this.hasScrolled) {
       this.hasScrolled = false
-      this.hasResized = true
 
       this.windowVerticalPosition = this.getWindowPositions().scrollTop