Fix tests #911
Fix tests #911
Conversation
A new version of Webmock is required to work with the new version of Ruby.
test/test_helper.rb
Outdated
| @@ -1,3 +1,5 @@ | |||
| $VERBOSE = nil | |||
There was a problem hiding this comment.
I think this is explicitly turned on in the rakefile https://github.com/alphagov/gds-api-adapters/blob/master/Rakefile#L14 - so we can probably remove it there rather than need to change the ruby runtime option.
There was a problem hiding this comment.
Ah, good spot, but unfortunately not. Ruby warnings aren't turned on by default, so my assumption is that one of the gems is doing it.
There was a problem hiding this comment.
Ah darn.
~~ has a play ~~
We can get the behaviour you're aiming by replacing t.verbose = true with t.warning = false
At the least we should remove the verbose off there if we do it here so we don't have one place turning verbosity up and one down.
There was a problem hiding this comment.
Yay, thank you - it's even better like that :-).
This removes warnings that were complicating the test output. All of the warnings were about other gems, except for one minor deprecation.
No description provided.