Change the expected Publishing API behaviour around included URLs #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Rails from 5.1 to 5.2 for the Publishing API seems to have changed the URLs which are included in responses, for example, for the next page of results. I've been trying to decide if this is better or worse, and I think that it's better. Mostly because percent encoding normally occurs when a URL is created from it's component parts [1], and these are full URLs. 1: https://tools.ietf.org/html/rfc3986#page-14
erino
approved these changes
Jan 4, 2019
thomasleese
deleted the
update-expected-publishing-api-behaviour-regarding-percent-encoding-of-urls-in-responses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Rails from 5.1 to 5.2 for the Publishing API seems to have
changed the URLs which are included in responses, for example, for the
next page of results.
I've been trying to decide if this is better or worse, and I think
that it's better. Mostly because percent encoding normally occurs when
a URL is created from it's component parts [1], and these are full URLs.
1: https://tools.ietf.org/html/rfc3986#page-14