Catch SocketError

We catch GdsApi::BaseError for scenarios when external services to the app
aren't available we keep the app being somewhat usable. Since SocketError
isn't handled by GDS API Adapters it means that this error can block someone
using the application.

Since GDS API Adapters wraps a variety of network related exceptions already
then it makes sense that it includes this one for consistency.

lib/gds_api/exceptions.rb

@@ -16,6 +16,7 @@ def raven_context
   class EndpointNotFound < BaseError; end
   class TimedOutException < BaseError; end
   class InvalidUrl < BaseError; end
+  class SocketErrorException < BaseError; end
 
   # Superclass for all 4XX and 5XX errors
   class HTTPErrorResponse < BaseError

lib/gds_api/json_client.rb

@@ -205,6 +205,9 @@ def do_request(method, url, params = nil, additional_headers = {})
     rescue Errno::ECONNRESET => e
       logger.error loggable.merge(status: 'connection_reset', error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
       raise GdsApi::TimedOutException.new
+    rescue SocketError => e
+      logger.error loggable.merge(status: 'socket_error', error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
+      raise GdsApi::SocketErrorException.new
     end
   end
 end

test/json_client_test.rb

@@ -63,6 +63,14 @@ def test_post_requests_timeout
     end
   end
 
+  def test_socket_error
+    url = "http://some.endpoint/some.json"
+    stub_request(:get, url).to_raise(SocketError)
+    assert_raises GdsApi::SocketErrorException do
+      @client.get_json(url)
+    end
+  end
+
   def test_get_should_raise_error_on_restclient_error
     url = "http://some.endpoint/some.json"
     stub_request(:get, url).to_raise(RestClient::ServerBrokeConnection)