Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor skip controller #1649

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor skip controller #1649

wants to merge 3 commits into from

Conversation

thomasiles
Copy link
Contributor

Small refactor of passing values to the skip controller views

Replace template locals with a single instance variable.

  • Remove back_link from skip controller
  • Remove template local from skip_controller
  • Add view tests for secondary_skip#edit

Trello card:

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

@thomasiles thomasiles force-pushed the refactor-skip-controller branch 2 times, most recently from b5327ee to 1bc3f09 Compare December 6, 2024 11:01
@thomasiles thomasiles force-pushed the refactor-skip-controller branch from 1bc3f09 to 9795c73 Compare December 12, 2024 10:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
59.7% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomasiles