Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 15.0.0 #213

Merged
merged 2 commits into from
Jan 11, 2016
Merged

Bump version to 15.0.0 #213

merged 2 commits into from
Jan 11, 2016

Conversation

tombye
Copy link
Contributor

@tombye tombye commented Jan 11, 2016

Includes

  • new notification banner format
    #211
    (breaking change)
  • changes to temporary messages example page
    #212
  • separation of temporary message style into
    placeholder [in
  • ability to add pattern-level grids in
    #212

Notes

The new notification banner commit introduced a breaking change.

The base temporary message styles were split out into a placeholder block to allow use across multiple patterns (by extending it):

https://github.com/alphagov/digitalmarketplace-frontend-toolkit/blob/master/toolkit/scss/shared_placeholders/_temporary-messages.scss

This means the existing temporary message pattern will break unless the new placeholder block is included in the main stylesheet of apps that use it.

Includes

- new notification banner format
  [#211](#211)
(breaking change)
- changes to temporary messages example page
  [#212](#212)
- separation of temporary message style into
  placeholder [in
- ability to add pattern-level grids [in
  #212](#212)
@TheDoubleK
Copy link
Contributor

Do we want to add a changelog to the toolkit, as we have been introducing elsewhere?
That notwithstanding 👍 for the version bump.

@tombye
Copy link
Contributor Author

tombye commented Jan 11, 2016

@TheDoubleK Yep, that's a good idea. Now added.

tombye added a commit that referenced this pull request Jan 11, 2016
@tombye tombye merged commit b06b4b6 into master Jan 11, 2016
@tombye tombye deleted the bump-to-15.0.0 branch January 11, 2016 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants