Add service unavailable banner #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Begin with moving the %temporary-message placeholder out of its current file.
| @import "_measurements.scss"; | ||
|
|
||
| // Required placeholders: | ||
| // @import "placeholders/_temporary-messages.scss"; |
There was a problem hiding this comment.
This reads like an import that’s been commented out. Might read better without the @import?
tombye
added a commit
that referenced
this pull request
Jan 6, 2016
Having it there is 'correct' but confusing as it sits underneath the @import declarations. See #211 (comment)
tombye
force-pushed
the
add-service-unavailable-banner
branch
from
1113622 to
9918d02
Compare
tombye
added a commit
that referenced
this pull request
Jan 6, 2016
Having it there is 'correct' but confusing as it sits underneath the @import declarations. See #211 (comment) and #211 (comment)
Having it there is 'correct' but confusing as it sits underneath the @import declarations. See #211 (comment) and #211 (comment)
tombye
force-pushed
the
add-service-unavailable-banner
branch
from
9918d02 to
aa44859
Compare
|
I've removed the |
|
LGTM now, excellent perseverance 👍 |
tombye
added a commit
that referenced
this pull request
Jan 8, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a notification banner for services no longer available to buy.
https://www.pivotaltracker.com/story/show/110062348
Note: this is a re-vamped version of #210