This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
Allow users to select a child benefit stop date in years up to 2013 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The child benefit start and stop dates are dynamically created lists. Changed the child benefit stop date to populate years upto four years in the past.
|
LGTM |
1 similar comment
|
LGTM |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Story: https://trello.com/c/dbyKP467/168-child-benefit-tax-calculator-change-stop-date-in-question-2-to-4-years-in-the-past
Motivation
A user can calculate their Child Benefit tax back to 7Jan 2013 in tax year 2012/13, as a consequence the Stop date should also include 2013 in the drop down boxes.
As the box is optional, if an end date isn't included, the calculator would calculate for a whole year, which isn't appropriate if the payments stopped during the year.
Dates are added to both selectors determining how many years to include (back and forward) starting from the current year.
Changed the stop year drop-down to include years up to four years ago.
Factcheck
Child benefit tax calculator
Expected Changes
URL on GOV.UK
Before
After