Add has_unconfirmed_email attribute, to be used in the account home page
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not just `!email_verified`:
- `email` - this is the email address the user registered with, or a
new email address they have confirmed.
- `email_verified` - the user needs to verify the email address they
registered with, this starts `false`, becomes `true`, and then never
returns to `false`
- `has_unconfirmed_email` - this is `true` if `email_verified` is
`false` OR the user has a pending email change to confirm
So,
if has_unconfirmed_email
if email_verified
show "finish changing your email address" banner
else
show "confirm your account" banner
end
end
We want to have the as many of the attributes needed to return the `GET /api/user` response stored locally as possible, so the homepage is nice and fast.
barrucadu
added a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Jun 17, 2021
huwd
reviewed
Jun 17, 2021
| @@ -16,6 +16,7 @@ | |||
| { | |||
| email: "[email protected]", | |||
| email_verified: true, | |||
There was a problem hiding this comment.
given this is a one-way-switch...
is there any utility in making this someting more like:
email_verified_on: "2021-01-01", where nil means never verified?
Wonder if that is a better form of history than true or `false?
Whereas has_unconfirmed_email is a representation of present state?
There was a problem hiding this comment.
atch, but then we'd have to update email_verified_at and perhaps that's just another thing that could go wrong. Probably nevermind!
There was a problem hiding this comment.
Another option might be to have a three state thing:
email_state = :confirmed
email_state = :pending_reconfirmation
email_state = :pending_confirmation
huwd
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not just
!email_verified:email- this is the email address the user registered with, or anew email address they have confirmed.
email_verified- the user needs to verify the email address theyregistered with, this starts
false, becomestrue, and then neverreturns to
falsehas_unconfirmed_email- this istrueifemail_verifiedisfalseOR the user has a pending email change to confirmSo,
And set the attribute through
PATCH /api/oidc-users/:sub.We want to have the as many of the attributes needed to return the
GET /api/userresponse stored locally as possible, so the homepageis nice and fast.
Trello card