Align AoSoA sub arrays #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
aosoa_align
branch
from
9f46000
to
df7fb38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #786 +/- ##
========================================
Coverage 98.72% 98.73%
========================================
Files 70 70
Lines 6842 6896 +54
========================================
+ Hits 6755 6809 +54
Misses 87 87 |
bernhardmgruber
force-pushed
the
aosoa_align
branch
3 times, most recently
from
463036b
to
14e3a6c
Compare
bernhardmgruber
force-pushed
the
aosoa_align
branch
from
14e3a6c
to
f6b1102
Compare
The fixed-size sub arrays of AoSoA are appropriately aligned now by default. This setting is customizable.
bernhardmgruber
force-pushed
the
aosoa_align
branch
from
f6b1102
to
3653134
Compare
|
Tested with n-body against develop, no difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not supported before, but is necessary for correctness. AoSoA now gets the same alignment parameter as AoS.