Update data to map #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
force-pushed
the
dom-data-map
branch
from
dab0933 to
123e298
Compare
alpadev
reviewed
Nov 20, 2020
rohit2sharma95
force-pushed
the
dom-data-map
branch
from
d9dcf8a to
cabbf8d
Compare
rohit2sharma95
force-pushed
the
dom-data-map
branch
from
cabbf8d to
61c1c5d
Compare
|
Now seems good? @alpadev 🙂 |
|
About the missing unit tests. Do you think we need to add some more? |
|
Yes, because I just removed some unit tests (Just to pass tests) instead of updating them. |
|
Who will do work on those tests 😄 |
|
As you like. |
|
Okay I will do then 👍 |
|
One of the tests you removed wasn't properly done anyway 😁 I think some of them are of no use anymore because you removed the key/bsKey but |
|
Okay, then I think we should move this PR to the main repository first 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: twbs#32123 (comment)
Though, this PR is missing some unit tests for data.js 😄